Add attributes to sail_doc_backend output, and add syntax sugar back in docs #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename _to_json to json_of_ to better match other usages Refactor Pretty_print_sail, adding a Pretty_print_sail.Printer functor which can be configured for different use cases. The module contains a include Printer (Default_print_config) so other code can just use Pretty_print_sail as before. The main use for this is in the documentation generation, as we want to be able to format code slightly differently than when we just dump the AST for debugging, e.g. re-introduce overloads. This is handled by the `resugar` flag in the pretty-printer config. The eventual ideal flow would be: constant-propagate -> pretty_print w/ resugar -> re-parse -> format_sail but we don't yet do the last two steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename to_json to json_of to better match other usages
Refactor Pretty_print_sail, adding a Pretty_print_sail.Printer functor which can be configured for different use cases. The module contains a
include Printer (Default_print_config)
so other code can just use Pretty_print_sail as before.
The main use for this is in the documentation generation, as we want to be able to format code slightly differently than when we just dump the AST for debugging, e.g. re-introduce overloads. This is handled by the
resugarflag in the pretty-printer config.The eventual ideal flow would be:
constant-propagate -> pretty_print w/ resugar -> re-parse -> format_sail
but we don't yet do the last two steps