Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined_gen for if-else type float_bits #516

Merged
merged 1 commit into from
May 6, 2024
Merged

Remove undefined_gen for if-else type float_bits #516

merged 1 commit into from
May 6, 2024

Conversation

Incarnation-p-lee
Copy link
Contributor

  • Remove the TODO workaround as fixed.

@Incarnation-p-lee
Remove undefined_gen for if-else type
2dac639 
* Remove the TODO workaround as fixed.

Signed-off-by: Pan Li <[email protected]>
@Incarnation-p-lee
Copy link
Contributor Author

The workaround was fixed by @Alasdair in commit ededb75. Thus remove this workaround and comments, and thanks @Alasdair for the quick fix in a day!

@Incarnation-p-lee Incarnation-p-lee changed the title Remove undefined_gen for if-else type Remove undefined_gen for if-else type float_bits May 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Test Results

    9 files  ±0     20 suites  ±0   0s ⏱️ ±0s
  620 tests ±0    620 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 990 runs  ±0  1 989 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 2dac639. ± Comparison against base commit a0dadc7.

@Incarnation-p-lee Incarnation-p-lee mentioned this pull request May 3, 2024
Open
13 tasks
@Alasdair Alasdair merged commit c779d64 into rems-project:sail2 May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Incarnation-p-lee @Alasdair