Make solver output failsafe #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Note I did this before your latest commit; I think that made the output a bit safer but it probably doesn't hurt to have this still.) |
Timmmm
force-pushed
the
user/timh/failsafe_sat
branch
from
54ab7fb to
2813d4f
Compare
`cvc5` can output three different things: 1. If it found a counter-example: ``` sat (... the model ...) ``` 2. If it didn't find a counter-example: ``` unsat (error "Cannot get model unless after a SAT or UNKNOWN response.") ``` 3. If you screw things up: ``` (error "Parse Error: model_smt_prop_fp_isnan.smt2:11.59: Symbol 'zf_is_NajhghjN_D_smt' not declared as a variable") ``` Note the last one has no `sat` or `unsat`, which meant it resulted in Sail printing `Solver could not find counterexample`, which is very misleading! This change makes it a bit safer by explicitly looking for both `sat` *and* `unsat`. I also changed all the prints in the file to print to stdout to be consistent.
Timmmm
force-pushed
the
user/timh/failsafe_sat
branch
from
2813d4f to
e372d59
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cvc5can output three different things:Note the last one has no
satorunsat, which meant it resulted in Sail printingSolver could not find counterexample, which is very misleading!This change makes it a bit safer by explicitly looking for both
satandunsat.I also changed all the prints in the file to print to stdout to be consistent.