Suggest most similar function id when we can't find a function type #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find identifier with smallest optimal string alignment (OSA) distance (within reason) and suggest it. The max difference is the identifier length - 3 clamped between 1 and 4. So a 4 character identifier will only suggest 1 change edits, a 5 character identifier 2 character edits and so on up to 4 edits.
Alasdair
force-pushed
the
osa_tyerror
branch
from
be1e2be to
524332f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find identifier with smallest optimal string alignment (OSA) distance (within reason) and suggest it. Only do this if the OSA distance is 4 or less, and the strings only differ in length be two or less to avoid suggesting unrelated identifiers. These numbers just felt ok with some basic testing, but maybe a better heuristic exists.