Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sail module system #383

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Sail module system #383

merged 12 commits into from
Nov 30, 2023

Conversation

Alasdair
Copy link
Collaborator

No description provided.

Overloads are always defined in the global scope (so they can be overloaded from anywhere)

Getting the overload members now only returns those in scope

There is a custom error message when we try to use an overload, and
none of it's members are in scope
Less nautical theme
While fixing this slightly clean up the related function checking code

Thanks to Rishiyur Nikhil for pointing out this wasn't allowed
Copy link

Test Results

       8 files  ±  0       19 suites  ±0   0s ⏱️ ±0s
   567 tests +  8     567 ✔️ +  8  0 💤 ±0  0 ±0 
1 875 runs  +14  1 874 ✔️ +14  1 💤 ±0  0 ±0 

Results for commit 2329b8c. ± Comparison against base commit 1144c85.

@Alasdair Alasdair marked this pull request as ready for review November 30, 2023 22:10
@Alasdair Alasdair merged commit 818a7b9 into sail2 Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant