Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance #358

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Improve performance #358

merged 2 commits into from
Oct 27, 2023

Conversation

Alasdair
Copy link
Collaborator

@Alasdair Alasdair commented Oct 27, 2023

Introduce a vistor pattern rewrite system for Jib IR, as suggested by Alastair Reid and based on the one in ASL interpreter

This massively reduces memory usage for the IR -> IR rewrites, with a corresponding increase in performance.

Allows modifying the IR with minimal copying, which should help with
memory usage and therefore performance
Add a simple heuristic for detecting constant folds that would produce large literals

Make is_union_constructor in type_env more efficient
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Test Results

       8 files  ±0       19 suites  ±0   0s ⏱️ ±0s
   550 tests ±0     550 ✔️ ±0  0 💤 ±0  0 ±0 
1 834 runs  ±0  1 833 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit c9b1877. ± Comparison against base commit 1d09489.

♻️ This comment has been updated with latest results.

@Alasdair Alasdair merged commit e4f9665 into sail2 Oct 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant