Make sure P_vector_subrange ids are returned by check_pattern_duplicates

src/lib/type_check.ml

@@ -1600,7 +1600,7 @@ let check_pattern_duplicates env pat =
                      Err_other "Regular binding is here"
                    )
                 )
-          | None -> ()
+          | None -> ids := Bindings.add subrange_id (Pattern_singleton l) !ids
         )
         !subrange_ids;
       !ids

src/lib/type_error.mli

@@ -119,6 +119,7 @@ val analyze_unresolved_quant :
 
 val string_of_type_error : type_error -> string * string option
 
+(** Convert a type error into a general purpose error from the Reporting file *)
 val to_reporting_exn : Parse_ast.l -> type_error -> exn
 
 val check_defs : Type_check.Env.t -> uannot Ast.def list -> Type_check.tannot Ast.def list * Type_check.Env.t

test/typecheck/pass/vector_subrange_mapping.sail

@@ -0,0 +1,11 @@
+default Order dec
+
+$include <prelude.sail>
+
+union Foo = {
+  Bar : bits(32)
+}
+
+mapping baz : Foo <-> bits(32) = {
+  Bar(imm) <-> imm[31 .. 16] @ imm[15 .. 0]
+}