Allow trailing commas in bitfield updates

rems-project · Apr 24, 2024 · 8986a12 · 8986a12
1 parent a3f4047
commit 8986a12
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/lib/parser.mly b/src/lib/parser.mly
@@ -859,7 +859,7 @@ vector_update:
     { VU_single (mk_exp (E_id $1) $startpos $endpos, mk_exp (E_id $1) $startpos $endpos)}
 
 vector_update_list:
-  | vector_update
+  | vector_update Comma?
     { [$1] }
   | vector_update Comma vector_update_list
     { $1 :: $3 }

diff --git a/test/typecheck/bitfield_trailing_comma.sail b/test/typecheck/bitfield_trailing_comma.sail
@@ -0,0 +1,15 @@
+default Order dec
+
+$include <prelude.sail>
+
+bitfield foo : bits(8) = {
+  f1 : 3 .. 0,
+  f2 : 7 .. 4,
+}
+
+val main : unit -> unit
+
+function main() = {
+  let x = [Mk_foo(0x00) with f1 = 0xA, f2 = 0xB, ];
+  ()
+}