Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update channel.ts #7489

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Update channel.ts #7489

merged 2 commits into from
Sep 20, 2023

Conversation

lifeiscontent
Copy link
Contributor

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

⚠️ No Changeset found

Latest commit: fe29e71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey
Copy link
Member

@lifeiscontent Can you please provide more details about what this change exactly is and why you did it exactly?

@MichaelDeBoey MichaelDeBoey reopened this Sep 20, 2023
@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Sep 20, 2023
@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Sep 20, 2023
@lifeiscontent
Copy link
Contributor Author

@MichaelDeBoey it's just to make the types sound, I noticed it, so decided to contribute a fix

@lifeiscontent
Copy link
Contributor Author

CC: @pcattori for sanity check since you seem to be the original author

@pcattori pcattori merged commit 7c19651 into remix-run:main Sep 20, 2023
9 checks passed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@lifeiscontent lifeiscontent deleted the patch-1 branch September 21, 2023 18:02
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants