Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: add version.txt to .gitignore #7483

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

chimame
Copy link
Contributor

@chimame chimame commented Sep 19, 2023

Thank you for developing this wonderful framework, Remix.

I have updated to v2 and tried using it and noticed that v2 outputs a version.txt when I do a build. However, I believe this is what Remix outputs at build time and not a file that should be included in git.

So I added it to gitignore.

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

⚠️ No Changeset found

Latest commit: bb70af0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori merged commit 9b280fe into remix-run:main Sep 19, 2023
5 checks passed
@chimame chimame deleted the add-version-text-to-gitignore branch September 19, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants