Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(start/v2): fix links #7433

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

brookslybrand
Copy link
Contributor

Couple of broken links in the upgrade docs, 2 right at the top 😬

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

⚠️ No Changeset found

Latest commit: ae6804d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

docs/start/v2.md Outdated
[meta-v2-rfc]: https://github.com/remix-run/remix/discussions/4462
[meta-v2-matches]: #the-matches-argument
[v1-16-release-notes]: https://github.com/remix-run/remix/releases/tag/remix%401.16.0
[v2-dev-config]: ../other-api/dev-v2
[v2-dev-config]: ../other-api/dev
[templates]: https://github.com/remix-run/remix/tree/main/templates
[v2-dev-docs]: ../other-api/dev-v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also wrong but I pushed a fix for it already

[remix-config]: ../file-conventions/remix-config
[flat-routes]: https://github.com/remix-run/remix/discussions/4482
[meta-v2]: ../route/meta-v2
[meta-v2]: ../route/meta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get this one in my changes so if you merge latest dev into here I think this will still need to get merged 👍

@brookslybrand brookslybrand force-pushed the brookslybrand/fix-upgrade-guide-links branch from 8dd2f67 to ae6804d Compare September 15, 2023 19:14
@brookslybrand brookslybrand merged commit 67513e9 into main Sep 15, 2023
2 checks passed
@brookslybrand brookslybrand deleted the brookslybrand/fix-upgrade-guide-links branch September 15, 2023 19:14
@MichaelDeBoey MichaelDeBoey changed the title docs: fix links in v2 upgrade doc docs(start/v2): fix links in v2 upgrade doc Sep 15, 2023
@MichaelDeBoey MichaelDeBoey changed the title docs(start/v2): fix links in v2 upgrade doc docs(start/v2): fix links Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants