Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use build.mode wherever possible #7089

Merged

Conversation

MichaelDeBoey
Copy link
Member

Follo-up of @pcattori's #6964

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2023

⚠️ No Changeset found

Latest commit: a138c5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 removed their request for review August 7, 2023 15:41
@pcattori pcattori merged commit c68c9a9 into remix-run:dev Aug 8, 2023
9 checks passed
@MichaelDeBoey MichaelDeBoey deleted the use-build-mode-where-possible branch August 8, 2023 17:01
@aaronadamsCA
Copy link
Contributor

@MichaelDeBoey, do you think this line would be safe to change as well? I'm assuming it was just overlooked at the time, but I was hoping to make sure.

if (process.env.NODE_ENV === "development") {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants