Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create config regardless of connection failures #179

Merged
merged 21 commits into from
Mar 26, 2024
Merged

Commits on Mar 13, 2024

  1. fix(connection): will retry connection for each message

    The channel will try to connect to the node for each message if a
    connection has not yet been established or if the node has disconnected.
    aleksander-vedvik committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    976444f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    301dbe2 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    d904f3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55d70fb View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. doc: mainly added a few doc comments and move if conn == nil

    The only code change is the move of "if conn == nil" from connect()
    to tryConnect(). It seems more logical to have this "guard check"
    at the top of a method, rather than right after starting the
    sendMsgs goroutine. There should be no semantic differences here,
    but who knows... this code is a bit intricate.
    
    Also adds some doc comment above some (internal) functions, mainly
    for documentation purposes and some language polish and typos.
    meling committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    dcc75e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. refactor(connection): guardclause and reduced lock time

    Added a guardclause to prevent goroutines being started more than once.
    
    Also, the channel will only lock when trying to recreate a
    nodestream, making it possible to retry when sending messages.
    aleksander-vedvik committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e78895c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d487c5f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d0b19bf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    720f01a View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Configuration menu
    Copy the full SHA
    5297977 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. fix: typos

    meling committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    de46337 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac26307 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    2dd48d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    32d9e81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da290f6 View commit details
    Browse the repository at this point in the history
  3. chore: call n.newContext() from within newChannel()

    We can avoid passing the context to channel, since we anyway have
    access to the relevant RawNode.
    meling committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    98fd597 View commit details
    Browse the repository at this point in the history
  4. fix: data race in correctable call type

    Since we now cancel pending messages, we have introduced a data
    race that doesn't appear to have been triggered before.
    meling committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3ded667 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ebe8380 View commit details
    Browse the repository at this point in the history
  6. chore: unexported testServerSetup

    To avoid having to support another test function, let's make it
    unexported for now. Currently, we only use it in one place; maybe
    we can harmonize it with some other helper.
    meling committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7c573fe View commit details
    Browse the repository at this point in the history
  7. fix: removed encoding.RegisterCodec

    It does not appear to be needed.
    meling committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d2815e8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b10575b View commit details
    Browse the repository at this point in the history