Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration creation with configurable replica count and wait time #159

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Configuration creation with configurable replica count and wait time #159

wants to merge 19 commits into from

Commits on Feb 27, 2022

  1. Configuration creation with configurable replica count and wait time

    Hanish Gogada authored and Hanish Gogada committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    5e65a9e View commit details
    Browse the repository at this point in the history

  2. Modified and added one more style of configuration creation

    Hanish Gogada authored and Hanish Gogada committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    5292458 View commit details
    Browse the repository at this point in the history

  3. Mostly minor tweaks

    @meling
    meling committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    5ea8e86 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Replaced waitgroup with errgroup and errChan 

    This fixes various problems with error reporting when running
tests with goroutines. Unfortunately, it still seems to fail for
Style1 for any replica count, but Style2 does not fail even for
replica counts up to 180.
    @meling
    meling committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    887ec36 View commit details
    Browse the repository at this point in the history

  2. Fixed error handling in createReplicas

    @meling
    meling committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    fdd4ffc View commit details
    Browse the repository at this point in the history

  3. Fixed too many open files problem 

    To avoid that the process create to many connections (open files)
each test should stop their servers.
    @meling
    meling committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    9f32140 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. A few more attempts to fix the number of all-to-all connections 

    This still contains the old versions that don't work, but I've
disabled them. Things should be cleaned up now that the new
version (seems to) work. Have been able to start 200 servers.
    @meling
    meling committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    d01de1e View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Fixed problem with style2

    @meling
    meling committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    936e44c View commit details
    Browse the repository at this point in the history

  2. Removed Style1 due to ordering problems

    @meling
    meling committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    c1c56cb View commit details
    Browse the repository at this point in the history

  3. Removed unused startListener() function

    @meling
    meling committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    07ed907 View commit details
    Browse the repository at this point in the history

  4. Fixed bug in error handling 

    Previously there was no way to know whether or not a goroutine had
in fact been started; henceforth, the errChan would be closed by
the defer since the createReplicas() call would reach the return
before all goroutines had the chance to send their err, causing a
panic. In this new version, we wait for all goroutines to start
before we check for errors on the channel.
    @meling
    meling committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    400d0ef View commit details
    Browse the repository at this point in the history

  5. Various cleanup and documentation

    @meling
    meling committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    2e934dd View commit details
    Browse the repository at this point in the history

  6. Renamed to retry test to all2all

    @meling
    meling committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    0c962f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Removed unnecessary close channel and simplified started loop

    @meling
    meling committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    920b95e View commit details
    Browse the repository at this point in the history

  2. Allocate space for all replicas in advance instead of append

    @meling
    meling committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    202000c View commit details
    Browse the repository at this point in the history

  3. Check err from createConfiguration

    @meling
    meling committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    9dc74b2 View commit details
    Browse the repository at this point in the history

  4. Added TestGrpcDial to weed out the problem

    @meling
    meling committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    5b5e8c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. chore: minor tweaks 

    Just wanted to check if this issue still persists (it does), but
thought I just make a few tweaks while I was at it.
    @meling
    meling committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e8aa996 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into retry

    @meling
    meling committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    19769fc View commit details
    Browse the repository at this point in the history