transform_quantile_to_pmf #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lshandross
reviewed
Sep 24, 2024
| if (! "quantile" %in% unique_output_types) { | ||
| cli::cli_abort("{.arg model_out_tbl} must contain predictions with output type 'quantile'.") | ||
| } | ||
| model_out_tbl <- model_out_tbl |> dplyr::filter(.data[["output_type"]] == "quantile") |
There was a problem hiding this comment.
If we're allowing the model_out_tbl to have non-quantile output types but are filtering those out, we should warn the user and/or note this in the function description (I prefer to do both).
There was a problem hiding this comment.
Thanks for the suggestion!
In 244ef6d I updated the documentation to clarify that the returned object has only the new-created pmf forecasts. I was thinking this would address your concern by more generally clarifying that everything in the input model_out_tbl is discarded. Does that make sense?
There was a problem hiding this comment.
yes it makes sense to me!
lshandross
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #10