Fix PostCommit Python sklearn on Python3.12 (apache#32171)

reeba212 · Dec 4, 2024 · f8d9ecc · f8d9ecc
1 parent fb9338b
commit f8d9ecc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/trigger_files/beam_PostCommit_Python.json b/.github/trigger_files/beam_PostCommit_Python.json
@@ -1,4 +1,5 @@
 {
-  "comment": "Modify this file in a trivial way to cause this test suite to run."
+  "comment": "Modify this file in a trivial way to cause this test suite to run.",
+  "modification": 1
 }
 
diff --git a/sdks/python/apache_beam/examples/inference/sklearn_examples_requirements.txt b/sdks/python/apache_beam/examples/inference/sklearn_examples_requirements.txt
@@ -16,7 +16,8 @@
 #
 
 # This should match the saved version of your trained model.
-# Beam's tests use sklearn 1.0.2 for their saved models.
+# Beam's tests use saved models with sklearn 1.0.2, which supports py3.7-3.10
+# However, newer sklearn is needed for testing on newer Python version
 scikit-learn==1.0.2; python_version < '3.11'
-# https://github.com/apache/beam/issues/27151 sklearn support Py311 in 1.2
-scikit-learn==1.2.2; python_version >= '3.11'
+# bump sklearn version when new Python version is supported
+scikit-learn==1.3.1; python_version >= '3.11'