BigQuey fix invalid null checks in io translation (apache#32515)

reeba212 · Dec 4, 2024 · be77afe · be77afe
1 parent 9e4efae
commit be77afe
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java b/...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java
@@ -291,7 +291,7 @@ public TypedRead<?> fromConfigRow(Row configRow, PipelineOptions options) {
           builder = builder.setMethod((TypedRead.Method) fromByteArray(methodBytes));
         }
         byte[] formatBytes = configRow.getBytes("format");
-        if (methodBytes != null) {
+        if (formatBytes != null) {
           builder = builder.setFormat((DataFormat) fromByteArray(formatBytes));
         }
         Collection<String> selectedFields = configRow.getArray("selected_fields");
@@ -641,7 +641,7 @@ public Write<?> fromConfigRow(Row configRow, PipelineOptions options) {
         }
         byte[] formatRecordOnFailureFunctionBytes =
             configRow.getBytes("format_record_on_failure_function");
-        if (tableFunctionBytes != null) {
+        if (formatRecordOnFailureFunctionBytes != null) {
           builder =
               builder.setFormatRecordOnFailureFunction(
                   (SerializableFunction<?, TableRow>)
@@ -654,7 +654,7 @@ public Write<?> fromConfigRow(Row configRow, PipelineOptions options) {
                   (AvroRowWriterFactory) fromByteArray(avroRowWriterFactoryBytes));
         }
         byte[] avroSchemaFactoryBytes = configRow.getBytes("avro_schema_factory");
-        if (tableFunctionBytes != null) {
+        if (avroSchemaFactoryBytes != null) {
           builder =
               builder.setAvroSchemaFactory(
                   (SerializableFunction) fromByteArray(avroSchemaFactoryBytes));