Skip to content

Commit

Permalink
Include Iceberg Hive runtime dependencies in IO expansion service con…
Browse files Browse the repository at this point in the history
…tainer (apache#32232)

* include iceberg hive runtime dependencies in io expansion service container

* trigger integration tests
  • Loading branch information
ahmedabu98 authored and reeba212 committed Dec 4, 2024
1 parent 7d71e89 commit 6deb959
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/trigger_files/IO_Iceberg_Integration_Tests.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 4
"modification": 5
}
7 changes: 6 additions & 1 deletion sdks/java/io/expansion-service/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,14 @@ dependencies {
implementation project(":sdks:java:io:kafka:upgrade")
permitUnusedDeclared project(":sdks:java:io:kafka:upgrade") // BEAM-11761

// Needed by Iceberg I/O users that use GCS for the warehouse location.
// **** IcebergIO runtime dependencies ****
runtimeOnly library.java.hadoop_client
// Needed when using GCS as the warehouse location.
implementation library.java.bigdataoss_gcs_connector
permitUnusedDeclared library.java.bigdataoss_gcs_connector
// Needed for HiveCatalog
runtimeOnly ("org.apache.iceberg:iceberg-hive-metastore:1.4.2")
runtimeOnly project(path: ":sdks:java:io:iceberg:hive:exec", configuration: "shadow")

runtimeOnly library.java.kafka_clients
runtimeOnly library.java.slf4j_jdk14
Expand Down
4 changes: 2 additions & 2 deletions sdks/java/io/iceberg/hive/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ dependencies {
// dependencies needed to run with iceberg's hive catalog
runtimeOnly ("org.apache.iceberg:iceberg-hive-metastore:$iceberg_version")
runtimeOnly project(path: ":sdks:java:io:iceberg:hive:exec", configuration: "shadow")
runtimeOnly library.java.bigdataoss_gcs_connector
runtimeOnly library.java.hadoop_client

// ----- below dependencies are for testing and will not appear in the shaded jar -----
// Beam IcebergIO dependencies
Expand All @@ -44,6 +42,8 @@ dependencies {
testImplementation project(":sdks:java:io:iceberg")
testRuntimeOnly project(path: ":runners:direct-java", configuration: "shadow")
testRuntimeOnly library.java.snake_yaml
testRuntimeOnly library.java.bigdataoss_gcs_connector
testRuntimeOnly library.java.hadoop_client

// needed to set up the test environment
testImplementation "org.apache.iceberg:iceberg-common:$iceberg_version"
Expand Down

0 comments on commit 6deb959

Please sign in to comment.