Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new react-json-tree? #490

Closed
akx opened this issue Oct 24, 2019 · 14 comments
Closed

Release new react-json-tree? #490

akx opened this issue Oct 24, 2019 · 14 comments

Comments

@akx
Copy link

akx commented Oct 24, 2019

Hey there!

There are downstream projects (the one I have my eye on is @nteract/outputs that could use a version of react-json-tree that doesn't have a dependency on babel-runtime.

Would it be possible to release a new version of react-json-tree?

EDIT 20200721: updated nteract/outputs link

@DDKnoll
Copy link

DDKnoll commented Jan 21, 2020

Can we please do this? We've had to clone the repo because you can't run babel 7 with this project because it specifies babel 6 as a dependency. We just need somebody to publish the code thats in the repo

@Methuselah96
Copy link
Member

@timdorr
Copy link
Member

timdorr commented May 6, 2020

No specific plan. I haven't yet looked through the state of the code right now to know if they should be published and at what version (patch vs minor vs major).

Maybe we can do a quick RC release so they don't show up on the latest npm tag and and break things for folks without some testing first. Plus, that will make sure I know how to publish these libraries (in case there are different steps than I'm used to)

@Methuselah96
Copy link
Member

Methuselah96 commented May 7, 2020

Makes sense. I've compiled an exhaustive changelog and made sure to find any changes since the last published version of the package (even packages that were last published from their original repo). Hopefully that will help with the publish. I've included a short summary under each change where appropriate.

Overall, it looks like almost all of the changes were internal changes (#449 looks like mostly linting and converting tests to Jest). Before the PRs you merged, I don't think there had been any unpublished bug fixes or feature changes. redux-devtools-inspector is the only package that has changes in the published package that haven't been made in this repo, and the only package that would cause a regression if published right now.

Changelog

react-json-tree

redux-devtools-instrument

redux-devtools

redux-devtools-log-monitor

redux-devtools-core

redux-slider-monitor

redux-devtools-inspector

devui

redux-devtools-cli

d3tooltip

map2tree

redux-devtools-test-generator

redux-devtools-trace-monitor

  • Last published from this repo
  • Changes since last publish:
    • None

@Methuselah96
Copy link
Member

Methuselah96 commented May 7, 2020

@timdorr After thinking about it a little more, I think it would make sense to just publish react-json-tree (in order to resolve #480 and #490 (and maybe #487)) and redux-devtools (in order to resolve #482).

redux-devtools-inspector can't be published until #430 and #431 are resolved in order to avoid a regression.

Based on #454 (comment), I don't think redux-devtools-core or redux-devtools-cli are finished yet, and so there's no need to publish those.

The rest of the packages don't have any non-internal changes.

@Methuselah96
Copy link
Member

Methuselah96 commented May 7, 2020

I don't know if it's helpful or not but here's a graph of the different repos getting merged together and the commit history since then: https://methuselah96.github.io/redux-devtools-app-testing/ (ignore the commit hashes and author). The last published version of each package is tagged.

@stclairdaniel
Copy link

Any updates here? I'd love an update - we're getting warnings in our test runs about deprecated React methods.

@Methuselah96
Copy link
Member

Methuselah96 commented Jul 20, 2020

No updates from me. @timdorr Is there anything I can do to help publish? I have a bit of free time on my hands and if I knew that fixes/changes will get published at some point it would help motivate me to work on this project more.

@timdorr
Copy link
Member

timdorr commented Jul 28, 2020

Hey @zalmoxisus or @alexkuz, can either of you grant me contributor access on npm? I'd like to help @Methuselah96 to get these updates published.

@Methuselah96
Copy link
Member

Methuselah96 commented Jul 28, 2020

@zalmoxisus @alexkuz @gaearon @jhen0409 @romseguy More specifically, the packages it would be great to have npm access to are:

Already in this monorepo/organization:

Hope to move to this monorepo:

We already have npm access to (no action required):

  • redux-devtools-instrument
  • redux-devtools
  • redux-devtools-log-monitor

You can give access to timdorr and/or methuselah96 on npm.

@zalmoxisus
Copy link
Collaborator

Hey guys! Thanks for all the effort here!
I granted access to @timdorr and @Methuselah96:

  • redux-slider-monitor
  • d3-state-visualizer
  • map2tree
  • react-json-tree
  • d3tooltip
  • redux-devtools-chart-monitor
  • redux-devtools-inspector
  • redux-devtools-test-generator
  • redux-devtools-extension
  • remotedev-serialize
  • devui
  • redux-devtools-trace-monitor
  • redux-devtools-core
  • redux-devtools-cli

Also for redux-devtools-dock-monitor, which is not used for the extension (and it's not in the list), but many are using it for "vanilla Redux Devtools".

Let me know if I missed some that I have access.

@Methuselah96
Copy link
Member

Methuselah96 commented Jul 30, 2020

@zalmoxisus Thanks for your help, that looks great!

@alexkuz The only one left that it would be nice to have access to from you is react-base16-styling. Can you get us npm access for that as well?

@Methuselah96
Copy link
Member

Published: https://github.com/reduxjs/redux-devtools/releases/tag/react-json-tree%400.12.0

@alexkuz
Copy link
Collaborator

alexkuz commented Aug 1, 2020

@timdorr @Methuselah96 here you are :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants