Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-json-tree to 0.12.0 #15

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

akx
Copy link
Member

@akx akx commented Aug 11, 2020

This removes transitive dependencies on @babel/runtime and core-js, hooray :)

See reduxjs/redux-devtools#490 & nteract/nteract#4636

This removes transitive dependencies on `@babel/runtime` and `core-js`, hooray :)
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for reaching out to the react-json-tree team about resolving this.

@captainsafia captainsafia merged commit 0c26d0f into nteract:master Aug 13, 2020
@captainsafia
Copy link
Member

Just published 3.0.10 with this fix.

@akx
Copy link
Member Author

akx commented Aug 14, 2020

Ugh, it looks like this isn't fully problem free either, since react-json-tree==0.12.0 depends on react-base16-styling, which implicitly requires babel-runtime (reported in alexkuz/react-base16-styling#2) 😩

EDIT: Whipped up alexkuz/react-base16-styling#11 and reduxjs/redux-devtools#587...

@akx akx deleted the upgrade-react-json-tree branch August 14, 2020 08:20
@captainsafia
Copy link
Member

@akx Ah! The journey continues. Thanks for helping improve the experience here. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants