-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16.9: componentWillReceiveProps has been renamed, and is not recommended for use. #480
Comments
This issue affects a good number of our projects. As the error says, it's for the upcoming async rendering. I'm not sure if this use will cause any issues with async rendering, and we should at least try If it does cause issues in React 17, then we'll cross that bridge when we come to it. Here's the output of
Is there anyone around to make these changes? If we made a PR, would it be reviewed? |
@Type1J it doesn't look as though this repo is maintained, so I'd reco forking and fixing there... and pointing the rest of us to your fork :) |
I'd hope that there would be at least 1 maintainer (someone that can merge PRs) to respond. I'll give it a few days. |
Any responses? I'd like to get a version of the JSON tree viewer at least that only uses the current React API. Maybe it's time to add a new maintainer or fork after all ... |
Looks like we are going to have to fork. This is a recurrent problem w/ open source. I don't get why maintainers can't even respond or delegate the repo to someone else?! |
@timdorr can you help please?? |
See #502. I've just gotten the keys to the castle, so it will take me a bit to get a handle on things and help out here. |
Super! Glad to have your steady hands @timdorr at the tiller! |
@timdorr Personally, I'm just glad that somebody is able to help out! Your work and time are appreciated. |
@timdorr this seems to still be an issue... is there a new version that's coming hopefully? |
See https://fb.me/react-async-component-lifecycle-hooks and https://reactjs.org/blog/2019/08/08/react-v16.9.0.html for details. At minimum, this needs the prefix
UNSAFE_
adding to these calls.The text was updated successfully, but these errors were encountered: