FSA Sequence #22
Closed
FSA Sequence #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase please? Would like to see if the tests are still running with the latest master. Otherwise this change looks fine to me. I'll reach out to @acdlite for that later. |
|
I've got a rebased version working at smarkets/redux-actions, looks like the tests do pass. |
|
Thanks for doing it. Is this PR still a thing? |
|
If this gets merged, I'll update my own PR as well with the rename. |
|
PR is dead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #19 without the extra arguments changes.
I was going to add documentation for handling sequence's but we don't have anything in the FSA spec that mentions this yet (requires resolution for redux-utilities/flux-standard-action#7).