Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 'npm test' script from master branch because the tests are not in that branch #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove 'npm test' script from master branch because the tests are not in that branch #20

wants to merge 1 commit into from

Conversation

schraj
Copy link

@schraj schraj commented Apr 14, 2017

fixes issue #19.

@pzrq
Copy link

pzrq commented Jan 30, 2018

@schraj With respect, I don't agree with this PR, but I would agree the documentation could be improved to make it clearer npm test won't pass until the tutorial is completed or the sagas branch checked out:

screen shot 2018-01-30 at 12 38 34 pm

@ianchanning
Copy link

The text should also be removed from the README, otherwise people following that will just get a different error when they run npm test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schraj @pzrq @ianchanning