Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #99: Add option to set file encoding to CSV reader. #100

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

awtimmering
Copy link
Contributor

Fixes #99

Let me know if this seems the right approach (right place to set the attribute).
Happy to see if I can add a unit test as well.

rdr = rdr.skip(getattr(self, "skip_head_rows", 0)) # chop unwanted header rows
rdr = rdr.skip(
getattr(self, "skip_head_rows", 0)
) # chop unwanted header rows
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this line shouldn't have changed. Would you managering have the latest commits which have the right line width for ruff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course, sorry for that!

@redstreet
Copy link
Owner

If you could also take a look at the failures above that would be great. One of them existed prior to your commit. Two of them are related to this PR. Contributing.md should show you what to do. Thanks!

fixed support for importers on non-UTF8 (e.g. Shift-JIS) text files.

Fixes redstreet#99.
@redstreet redstreet merged commit e82d4c5 into redstreet:main Apr 7, 2024
2 checks passed
@redstreet
Copy link
Owner

No worries, and perfect, merged, thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV importer does not allow specifying encoding
2 participants