fix: prevent index out of bounds on nocontent empty query results (#353)

fix: prevent index out of bounds on nocontent empty query results (resolves gh-351)
redis · Sep 23, 2023 · 4d087fe · 4d087fe
1 parent fce58bf
commit 4d087fe
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/...-spring/src/main/java/com/redis/om/spring/search/stream/ReturnFieldsSearchStreamImpl.java b/...-spring/src/main/java/com/redis/om/spring/search/stream/ReturnFieldsSearchStreamImpl.java
@@ -289,9 +289,13 @@ private Stream<T> resolveStream() {
       if (useNoContent) {
         query.setNoContent();
         SearchResult searchResult = entitySearchStream.getOps().search(query);
-        String keySample = searchResult.getDocuments().get(0).getId();
-        int idBegin = keySample.indexOf(":") + 1;
-        resolvedStream = (Stream<T>) searchResult.getDocuments().stream().map(Document::getId).map(key -> key.substring(idBegin));
+        if (searchResult.getDocuments().size() > 0) {
+          String keySample = searchResult.getDocuments().get(0).getId();
+          int idBegin = keySample.indexOf(":") + 1;
+          resolvedStream = (Stream<T>) searchResult.getDocuments().stream().map(Document::getId).map(key -> key.substring(idBegin));
+        } else {
+          resolvedStream = (Stream<T>) Stream.empty();
+        }
       } else {
         boolean returningFullEntity = (returning.stream().anyMatch(foi -> foi.getSearchAlias().equalsIgnoreCase("__this")));
 

diff --git a/redis-om-spring/src/test/java/com/redis/om/spring/search/stream/EntityStreamDocsTest.java b/redis-om-spring/src/test/java/com/redis/om/spring/search/stream/EntityStreamDocsTest.java
@@ -2431,4 +2431,14 @@
       assertThat(d.getId()).isNotNull();
     });
   }
+
+  @Test void testMapAgainstEmptyResults() {
+    List<String> names = entityStream //
+      .of(Company.class) //
+      .filter(Company$.NAME.startsWith("Open"))
+      .map(Company$.ID)
+      .collect(Collectors.toList());
+
+    assertThat(names).isEmpty();
+  }
 }
diff --git a/redis-om-spring/src/test/java/com/redis/om/spring/search/stream/EntityStreamHashTest.java b/redis-om-spring/src/test/java/com/redis/om/spring/search/stream/EntityStreamHashTest.java
@@ -1520,4 +1520,14 @@
     List<String> names = companies.stream().map(Company::getName).collect(Collectors.toList());
     assertThat(names).contains("RedisInc");
   }
+
+  @Test void testMapAgainstEmptyResults() {
+    List<String> names = entityStream //
+      .of(Company.class) //
+      .filter(Company$.NAME.startsWith("Open"))
+      .map(Company$.ID)
+      .collect(Collectors.toList());
+
+    assertThat(names).isEmpty();
+  }
 }