Release galaxy-1.36.1

galaxy.yml

@@ -24,7 +24,7 @@ namespace: sap
 
 name: sap_operations
 
-version: 1.36.0
+version: 1.36.1
 
 readme: README.md
 

roles/general_preconfigure/defaults/main.yml

@@ -20,7 +20,8 @@
 # If not, see <https://www.gnu.org/licenses/>.
 
 ---
-general_preconfigure_tmpfs_size_gb: "
+general_preconfigure_tmpfs_size_gb: "\
   {{ ((0.75 * (ansible_facts['memtotal_mb'] | default(0) + ansible_facts['swaptotal_mb'] | default(0))) / 1024)
   | round | int }}"
 general_preconfigure_reboot: postpone
+general_preconfigure_reboot_timeout: 3600

roles/general_preconfigure/handlers/main.yml

@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: GPL-3.0-only
+# SPDX-FileCopyrightText: 2024 Red Hat, Project Atmosphere
+#
+# Copyright 2024 Red Hat, Project Atmosphere
+#
+# This program is free software: you can redistribute it and/or modify it under the terms of the GNU
+# General Public License as published by the Free Software Foundation, version 3 of the License.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without
+# even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+# See the GNU General Public License for more details.
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# You should have received a copy of the GNU General Public License along with this program.
+# If not, see <https://www.gnu.org/licenses/>.
+
+---
+- name: Reboot
+  ansible.builtin.reboot:
+    reboot_timeout: "{{ general_preconfigure_reboot_timeout }}"
+  become: true
+  become_user: root

roles/general_preconfigure/meta/argument_specs.yml

@@ -33,9 +33,10 @@ argument_specs:
           none - no reboot will be be required after role applied,
           role will not install packages that might require reboot. Not all requirements can be fulfilled that way.
           List of packages to be skipped see <https://access.redhat.com/solutions/27943>
-          postpone - (default behavior) reboot might be required after packages installation by the role,
-          role will not reboot machine, role will not notify reboot action, in this case reboot has to be handled separately by the user.
-          now - role will force reboot of the host at the end of the execution - this is not idempotent and reboot will be forced each time role is executed.
+          postpone - (default behavior) role will not flush handlers at the end of execution, but reboot handler will be notified,
+          in this case this is a user obligation to flush handlers (and thus reboot the host).
+          now - role will flush handlers at the end of the execution - this is might not be desirable,
+          in situations when another role that requires reboot will run after.
         type: str
         required: false
         default: postpone
@@ -48,6 +49,11 @@ argument_specs:
         type: str
         default: "{% raw %}{{ ((0.75 * (ansible_facts['memtotal_mb'] + ansible_facts['swaptotal_mb'])) / 1024) | round | int }}{% endraw %}"
         required: false
+      general_preconfigure_reboot_timeout:
+        description: Timeout for reboot handler, see how reboot is handled in general_preconfigure_reboot parameter description
+        type: int
+        required: false
+        default: 3600
 
   __limitations__:
     options: {}

roles/general_preconfigure/tasks/main.yml

@@ -103,6 +103,6 @@
   ansible.builtin.include_tasks:
     file: "rhel-{{ ansible_facts['distribution_major_version'] }}.yml"
 
-- name: Reboot (if reboot = now)
-  ansible.builtin.reboot:
+- name: Flush handlers (if reboot = now)
+  ansible.builtin.meta: flush_handlers
   when: general_preconfigure_reboot == 'now'

roles/general_preconfigure/tasks/packages.yml

@@ -32,6 +32,7 @@
         skip_broken: "{{ general_preconfigure_packages_skip_broken }}"
       become: true
       become_user: root
+      notify: Reboot
 
     - name: Install package groups
       ansible.builtin.dnf:
@@ -41,3 +42,4 @@
         skip_broken: "{{ general_preconfigure_packages_skip_broken }}"
       become: true
       become_user: root
+      notify: Reboot

roles/general_preconfigure/vars/main.yml

@@ -22,7 +22,7 @@
 ---
 general_preconfigure_major_version: "{{ ansible_facts['distribution_major_version'] }}"
 general_preconfigure_architecture: "{{ ansible_facts['architecture'] }}"
-general_preconfigure_kernel_parameters: "
+general_preconfigure_kernel_parameters: "\
   {{
   general_preconfigure_kernel_parameters_mapping\
   [ansible_facts['distribution_major_version']]
@@ -57,21 +57,21 @@ general_preconfigure_services:
     state: started
     enabled: true
 
-general_preconfigure_packages: "
+general_preconfigure_packages: "\
   {{
   general_preconfigure_packages_mapping\
   [general_preconfigure_major_version]\
   [general_preconfigure_architecture]
   }}"
 
-general_preconfigure_package_groups: "
+general_preconfigure_package_groups: "\
   {{
   general_preconfigure_package_groups_mapping\
   [general_preconfigure_major_version]\
   [general_preconfigure_architecture]
   }}"
 
-general_preconfigure_selinux: "
+general_preconfigure_selinux: "\
   {{
   general_preconfigure_selinux_mapping\
   [general_preconfigure_major_version]

roles/hana_preconfigure/vars/main.yml

@@ -21,7 +21,7 @@
 
 ---
 hana_preconfigure_tuned_profile: sap-hana
-hana_preconfigure_packages: "
+hana_preconfigure_packages: "\
   {{
   hana_preconfigure_packages_mapping\
   [ansible_facts['distribution_major_version']]\
@@ -46,7 +46,7 @@ hana_preconfigure_services:
     enabled: false
     state: stopped
 
-hana_preconfigure_kernel_parameters: "
+hana_preconfigure_kernel_parameters: "\
   {{
   hana_preconfigure_kernel_parameters_mapping\
   [ansible_facts['distribution_major_version']]\