Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to default namespace before deletion of grafana namespace #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

switch to default namespace before deletion of grafana namespace #19

wants to merge 1 commit into from

Conversation

ekuric
Copy link

@ekuric ekuric commented Mar 30, 2023

Ensure we are in default namespace before

oc delete ns {{ grafana_namespace }}

is executed.

pcuzner
pcuzner previously approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@pcuzner pcuzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@pcuzner
Copy link
Collaborator

pcuzner commented Apr 18, 2023

@ekuric looks like you need to rebase, the README has changed since you cloned

@pcuzner pcuzner self-requested a review April 26, 2023 04:13
@pcuzner pcuzner dismissed their stale review April 26, 2023 04:14

Waiting on rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuzner pcuzner Awaiting requested review from pcuzner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekuric @pcuzner