Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #370: run deployment_bastion_node_cleanup only on the same server uuid #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ioggstream
Copy link
Contributor

This patch should fix the very annoying #370

Before unregistering the node it checks if the server uuid attached to the OS::Heat::DeploymentConfig is the same of the target machine.

As the ip address could be reused in time (eg. if the server is removed instead of just marked unhealthy) I used the server uuid, relying on

/var/lib/cloud/instances/$node_id 

Feedback welcome + Peace,
R:

@markllama
Copy link
Contributor

I'm going to see if I can try this this week. it may be that this also solves the problem with a stack delete hanging.

@ioggstream
Copy link
Contributor Author

@markllama great. Please let me know if you need any kind of support. Feel free to email:[email protected] / irc:ioggstream me.

@ioggstream ioggstream force-pushed the 370-fix-dont-unregister-new-infra branch from 825021d to 88d0dbf Compare August 11, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants