Adding trailing backslash rule #899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #857 |
|
🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-899.surge.sh 🎊 |
aireilly
force-pushed
the
trailing-backslash
branch
from
fa069f1
to
9e54a54
Compare
aireilly
force-pushed
the
trailing-backslash
branch
from
9e54a54
to
9376b5c
Compare
apinnick
reviewed
Oct 30, 2024
| .Example | ||
| [source,terminal] | ||
| ---- | ||
| $ az role assignment create --role "<privileged_role>" \// <1> |
There was a problem hiding this comment.
Could you add a "normal" backslash without a callout to the testvalid file?
$ az role assignment \
create --role "<privileged_role>"
There was a problem hiding this comment.
This will trigger the rule. I'll see if I can refine the regex to cater for this.
There was a problem hiding this comment.
I ran into a similar issue when I tried to create a Vale rule that would flag lines in code that were missing backslashes. :-( Never did find a good solution.
There was a problem hiding this comment.
Could handle it with a script rule for sure.
aireilly
force-pushed
the
trailing-backslash
branch
2 times, most recently
from
d295423
to
792bc2a
Compare
aireilly
force-pushed
the
trailing-backslash
branch
from
792bc2a
to
347655f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trailing backslashes in codeblocks break the openshift-docs Asciibinder build.