Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Telemetry type #917

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Export Telemetry type #917

wants to merge 4 commits into from

Conversation

remcohaszing
Copy link
Contributor

What does this PR do?

Export the Telemetry type.

Alternatively it could be defined in yamlLanguageService.ts.

What issues does this PR fix or reference?

This is used by monaco-yaml.

Is it tested? How?

No.

@remcohaszing
Export Telemetry type
55ffa3f 
This is used by `monaco-yaml`.
@gorkem
Copy link
Collaborator

gorkem commented Oct 7, 2023

Can we alternately add telemetry.ts to index.ts ? This would also export TelemetryEvent which I feel maybe needed if a client really wants to send events.

@remcohaszing
Copy link
Contributor Author

I think you meant to move it into yamlLanguageService, of which everything is also re-exported in index.ts. Otherwise language service code would have to import language server code.

@coveralls
Copy link

Coverage Status

coverage: 84.071%. remained the same
when pulling 4212cc9 on remcohaszing:export-telemetry
into d354c58 on redhat-developer:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msivasubramaniaan msivasubramaniaan Awaiting requested review from msivasubramaniaan msivasubramaniaan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@remcohaszing @gorkem @coveralls @msivasubramaniaan