-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: doNotSuggest for property and value completion #911
base: main
Are you sure you want to change the base?
fix: doNotSuggest for property and value completion #911
Conversation
66ebd31
to
bd11e21
Compare
Hello @msivasubramaniaan, can I ask you for a review, please? |
We do inherit the @aeschli Is this something interesting for vscode json language service too? |
Yes, if you want to make a PR against the json-language-service that would be great. |
bd11e21
to
d7c2154
Compare
Hi, I created PR for this functionality microsoft/vscode-json-languageservice#213 |
d7c2154
to
769f53f
Compare
What does this PR do?
exclude doNotSuggest schema from autocompletion
doNotSuggest
was already there but implemented only for the simple object properties.This PR uses
doNotSuggest
also for other scenarios: anyOf, valuesWhat issues does this PR fix or reference?
related to the previous unfinished PR for the deprecated property:
#833
Is it tested? How?
adds unit tests