Adjust the document paste handling provider. #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- provideDocumentPasteEdits API was updated in VS Code 1.88.0 Signed-off-by: Roland Grunberg <[email protected]>
|
what happens if the user uses copy & paste in an old VS Code version (e.g.1.87) against this PR change? |
|
From trying out the change on an older VS Code (eg. 1.87), it simply pastes the text as usual with no modification. AFAICT the paste handling request isn't even sent to the language server. |
|
I see. As long as it doesn't break the default system copy/paste behavior in an older vscode, it's fine to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC'ing @testforstephen for awareness. I would guess we're fine to not support the older API for those staying on previous versions.