Should explicitly report the fatal settings error #2451
+49
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2022
snjeza
changed the title
Signed-off-by: Snjezana Peco <[email protected]>
snjeza
changed the title
rgrunber
requested changes
May 26, 2022
There was a problem hiding this comment.
Seems pretty reasonable, but things like :
~/Scripts/org.eclipse.jdt.core.prefs
${user.home}/Scripts/org.eclipse.jdt.core.prefs
are valid.
We did this using https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ResourceUtils.java#L249 on the server side.
Is there a way to allow such cases for now ?
I will try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2429
Requires eclipse-jdtls/eclipse.jdt.ls#2089
Test vsix: https://github.com/snjeza/vscode-test/raw/master/java-1.6.1.vsix
Signed-off-by: Snjezana Peco [email protected]