Added e2e tests prcheck workflow #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xbabalov
force-pushed
the
prCheck
branch
2 times, most recently
from
19a6d6c
to
fe55658
Compare
odockal
requested changes
Nov 1, 2024
.github/workflows/pr-check.yaml
Outdated
| path: podman-desktop | ||
|
|
||
| - name: Update podman |
.github/workflows/pr-check.yaml
Outdated
| podman build -t local_sandbox_image ./ | ||
| CONTAINER_ID=$(podman create localhost/local_sandbox_image --entrypoint "") | ||
| podman export $CONTAINER_ID > /tmp/local_sandbox_image.tar |
There was a problem hiding this comment.
please update according to ai-lab changes.
Signed-off-by: xbabalov <[email protected]>
Signed-off-by: xbabalov <[email protected]>
Signed-off-by: xbabalov <[email protected]>
|
This issue prevents the tests from passing #245. Tests pass if we delete the resources folder beforehand. |
odockal
approved these changes
Nov 13, 2024
|
@dgolovin Do you suggest we merge this PR failing on this issue #245 or do I delete the needed folder, we merge it passing and when the issue is fixed the tests fail and I fix additionally after that if needed? The passing tests would help when trying to test other PRs later but if the blocker is planned to get fixed soon we can just merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #200