Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release script to stay in same repo #46

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Feb 16, 2024

In the step tag the script is modifying the package.json file, but we are building the image from another step, where we checkout the repository agin, and the changes on the package.json file are lost

@feloy feloy requested a review from benoitf February 16, 2024 15:03
Copy link

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to checkout from the tag, not change the order

@benoitf
Copy link

benoitf commented Feb 16, 2024

    steps:
      - uses: actions/checkout@v4
        with:
          ref: 

@feloy feloy requested a review from benoitf February 16, 2024 15:23
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feloy feloy merged commit 6b96bdb into redhat-developer:main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants