ci: build image for self hosted gh runner test #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianriobo
reviewed
Nov 28, 2024
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] |
There was a problem hiding this comment.
I think we can remove push, as I set up rule for require rebase on PRs...meaning just before merge we already tested with latest changes in code. WDYT?
There was a problem hiding this comment.
yeah we can remove it in that case
this workflow uses path filters and runs only when files related to self hosted runner code changes it then triggers the workflow for the self hosted runner test, making the workflow run only for file changes in the self hosted runner modules
changes the build-on-hosted-runner workflow to run upon completion of the build-img-ghrunner workflow
adrianriobo
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this workflow uses path filters and runs only when files related to self hosted runner code changes
it then triggers the workflow for the self hosted runner test, making the workflow run only for file changes in the self hosted runner modules