Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update argo rollout manager (#813)" #815

Merged

Conversation

anandf
Copy link
Member

@anandf anandf commented Nov 26, 2024

This reverts commit ccad01f.

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@anandf anandf requested a review from jgwest November 26, 2024 15:51
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from anandf. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This reverts commit ccad01f.

Signed-off-by: Anand Francis Joseph <[email protected]>
@anandf anandf force-pushed the revert_rollout_manager_update branch from 3f76916 to 19f1f20 Compare November 26, 2024 15:52
@anandf
Copy link
Member Author

anandf commented Nov 27, 2024

/retest-required

@jgwest
Copy link
Collaborator

jgwest commented Nov 27, 2024

/retest

Copy link
Collaborator

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @anandf!

@jgwest
Copy link
Collaborator

jgwest commented Nov 28, 2024

/retest

@jgwest jgwest merged commit 6faa164 into redhat-developer:v1.15 Dec 3, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants