Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade argocd-operator versions v0.13.0 #810

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

Mangaal
Copy link
Contributor

@Mangaal Mangaal commented Nov 22, 2024

What type of PR is this?
/kind chore

What does this PR do / why we need it:
Upgrade argocd-operator versions

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Mangaal <[email protected]>
Copy link

openshift-ci bot commented Nov 22, 2024

Hi @Mangaal. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Member

svghadi commented Nov 22, 2024

/ok-to-test

Signed-off-by: Mangaal <[email protected]>
@Mangaal Mangaal marked this pull request as ready for review November 22, 2024 09:01
@svghadi svghadi removed the request for review from ciiay November 22, 2024 09:12
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Copy link
Member

svghadi commented Nov 22, 2024

/lgtm

Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svghadi
Copy link
Member

svghadi commented Nov 22, 2024

/retest

1 similar comment
@Mangaal
Copy link
Contributor Author

Mangaal commented Nov 25, 2024

/retest

Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Copy link
Member

svghadi commented Nov 25, 2024

/approve

@svghadi
Copy link
Member

svghadi commented Nov 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2024
@anandf
Copy link
Member

anandf commented Nov 25, 2024

/approve

Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf, svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anandf
Copy link
Member

anandf commented Nov 25, 2024

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit e6f02a3 into redhat-developer:v1.15 Nov 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants