Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade argocd-operator versions #803

Conversation

ishitasequeira
Copy link
Collaborator

What type of PR is this?
/kind chore

What does this PR do / why we need it:
Upgrade argocd-operator versions

Test acceptance criteria:

  • Unit Test
  • E2E Test

Copy link

openshift-ci bot commented Nov 6, 2024

@ishitasequeira: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind chore

What does this PR do / why we need it:
Upgrade argocd-operator versions

Test acceptance criteria:

  • Unit Test
  • E2E Test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ishitasequeira ishitasequeira changed the base branch from master to v1.14 November 6, 2024 05:29
@ishitasequeira ishitasequeira force-pushed the upgrade-argocd-and-operator-versions branch from a4a698d to c170a0b Compare November 6, 2024 05:30
Signed-off-by: Ishita Sequeira <[email protected]>
@ishitasequeira ishitasequeira force-pushed the upgrade-argocd-and-operator-versions branch from c170a0b to 7fe4c9c Compare November 6, 2024 05:31
@svghadi
Copy link
Member

svghadi commented Nov 6, 2024

@ishitasequeira
Copy link
Collaborator Author

Can you also update the CRDs here? https://github.com/redhat-developer/gitops-operator/tree/master/config/crd/bases

@svghadi , the CRDs seem to be already updated. That is why no change came in the CRDs.

@@ -8,7 +8,7 @@ commands:
# These variables need to be maintained according to the component matrix: https://spaces.redhat.com/display/GITOPS/GitOps+Component+Matrix
expected_kustomizeVersion='v5.4.2'
expected_helmVersion='v3.15.2'
expected_argocdVersion='v2.12.6+4dab5bd'
expected_argocdVersion='v2.12.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a short commit id too added isn't it ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be matched to the version in go.mod which is automatically updated when running go mod download && go mod tidy && go mod vendor

Copy link
Member

@anandf anandf Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test will fail as it will try to match v2.12.7+4d70c51

Copy link
Collaborator Author

@ishitasequeira ishitasequeira Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test seems to be succeeding. The version in go.mod is also reflecting v2.12.7 matching the value in test. I will try running the test locally once more.

@svghadi
Copy link
Member

svghadi commented Nov 7, 2024

@svghadi , the CRDs seem to be already updated. That is why no change came in the CRDs.

@ishitasequeira - Can you confirm this again? I believe there is a CRD change. In your argoproj-labs/argocd-operator#1591 PR, I see a new autoHealAttemptsCount field in Application CRD which is not present in v1.14 branch in this repo.

ishitasequeira and others added 2 commits November 7, 2024 07:28
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira
Copy link
Collaborator Author

/test v4.14-kuttl-sequential

@redhat-developer redhat-developer deleted a comment from openshift-ci bot Nov 7, 2024
@ishitasequeira
Copy link
Collaborator Author

/test v4.14-kuttl-sequential

@ishitasequeira
Copy link
Collaborator Author

/retest

@ishitasequeira
Copy link
Collaborator Author

/test v4.14-kuttl-sequential

Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandf
Copy link
Member

anandf commented Nov 8, 2024

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fee6a53 into redhat-developer:v1.14 Nov 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants