-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade argocd-operator versions #803
chore: Upgrade argocd-operator versions #803
Conversation
@ishitasequeira: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a4a698d
to
c170a0b
Compare
Signed-off-by: Ishita Sequeira <[email protected]>
c170a0b
to
7fe4c9c
Compare
Can you also update the CRDs here? |
@svghadi , the CRDs seem to be already updated. That is why no change came in the CRDs. |
@@ -8,7 +8,7 @@ commands: | |||
# These variables need to be maintained according to the component matrix: https://spaces.redhat.com/display/GITOPS/GitOps+Component+Matrix | |||
expected_kustomizeVersion='v5.4.2' | |||
expected_helmVersion='v3.15.2' | |||
expected_argocdVersion='v2.12.6+4dab5bd' | |||
expected_argocdVersion='v2.12.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a short commit id too added isn't it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be matched to the version in go.mod
which is automatically updated when running go mod download && go mod tidy && go mod vendor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test will fail as it will try to match v2.12.7+4d70c51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test seems to be succeeding. The version in go.mod
is also reflecting v2.12.7
matching the value in test. I will try running the test locally once more.
@ishitasequeira - Can you confirm this again? I believe there is a CRD change. In your argoproj-labs/argocd-operator#1591 PR, I see a new |
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test v4.14-kuttl-sequential |
/test v4.14-kuttl-sequential |
/retest |
/test v4.14-kuttl-sequential |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fee6a53
into
redhat-developer:v1.14
What type of PR is this?
/kind chore
What does this PR do / why we need it:
Upgrade argocd-operator versions
Test acceptance criteria: