Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard for Rollouts #756

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Add dashboard for Rollouts #756

merged 4 commits into from
Aug 9, 2024

Conversation

gnunn1
Copy link
Collaborator

@gnunn1 gnunn1 commented Aug 2, 2024

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

This PR adds a new dashboard to the OpenShift Console for Rollouts. It leverages the metrics provided by the operator deployed servicemonitor for Rollouts. This dashboard is based on the upstream Argo Rollouts dashboard but tuned and tweaked for the Console.

Have you updated the necessary documentation?

  • [ *] Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

No issue has been opened for this but can open one if needed.

Test acceptance criteria:

  • [*] Unit Test
  • E2E Test

This is covered by the existing dashboards unit tests.

How to test changes / Special notes to the reviewer:

Run the operator and validate that a Rollouts Dashboard appears in the OpenShift console. Assuming Rollouts are deployed on the various graphs will populate with metrics.

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Aug 2, 2024
@openshift-ci openshift-ci bot requested review from ciiay and jgwest August 2, 2024 16:44
Copy link

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rnapoles-rh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 2, 2024

Hi @gnunn1. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jgwest
Copy link
Collaborator

jgwest commented Aug 7, 2024

/ok-to-test

@jgwest
Copy link
Collaborator

jgwest commented Aug 7, 2024

@gnunn1 Sent you an invite to allow you to skip /ok-to-test requirement.

@jgwest jgwest removed the request for review from ciiay August 7, 2024 09:16
@gnunn1
Copy link
Collaborator Author

gnunn1 commented Aug 8, 2024

/retest

@jgwest
Copy link
Collaborator

jgwest commented Aug 9, 2024

/retest

Failed on:
--- FAIL: kuttl/harness/1-074_validate_terminating_namespace_block (27.84s)
--- FAIL: kuttl/harness/1-057_validate_notifications (105.24s)

Copy link
Collaborator

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works great, thanks @gnunn1!

@jgwest
Copy link
Collaborator

jgwest commented Aug 9, 2024

/approved
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 9, 2024
@jgwest jgwest merged commit 658f46b into redhat-developer:master Aug 9, 2024
19 of 20 checks passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
* Work in progress for Rollouts Dashboard

Signed-off-by: Gerald Nunn <[email protected]>

* First iteration of Rollouts dashboard

Signed-off-by: Gerald Nunn <[email protected]>

* Add dashboard for Rollouts

Signed-off-by: Gerald Nunn <[email protected]>

* Include mention of Rollouts dashboard

Signed-off-by: Gerald Nunn <[email protected]>

---------

Signed-off-by: Gerald Nunn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants