-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboard for Rollouts #756
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @gnunn1. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@gnunn1 Sent you an invite to allow you to skip |
Signed-off-by: Gerald Nunn <[email protected]>
Signed-off-by: Gerald Nunn <[email protected]>
Signed-off-by: Gerald Nunn <[email protected]>
Signed-off-by: Gerald Nunn <[email protected]>
/retest |
/retest Failed on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and works great, thanks @gnunn1!
/approved |
* Work in progress for Rollouts Dashboard Signed-off-by: Gerald Nunn <[email protected]> * First iteration of Rollouts dashboard Signed-off-by: Gerald Nunn <[email protected]> * Add dashboard for Rollouts Signed-off-by: Gerald Nunn <[email protected]> * Include mention of Rollouts dashboard Signed-off-by: Gerald Nunn <[email protected]> --------- Signed-off-by: Gerald Nunn <[email protected]>
What type of PR is this?
What does this PR do / why we need it:
This PR adds a new dashboard to the OpenShift Console for Rollouts. It leverages the metrics provided by the operator deployed servicemonitor for Rollouts. This dashboard is based on the upstream Argo Rollouts dashboard but tuned and tweaked for the Console.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
No issue has been opened for this but can open one if needed.
Test acceptance criteria:
This is covered by the existing dashboards unit tests.
How to test changes / Special notes to the reviewer:
Run the operator and validate that a Rollouts Dashboard appears in the OpenShift console. Assuming Rollouts are deployed on the various graphs will populate with metrics.