GITOPS-477 Add back non-kuttl test execution.

[trdoyle81]

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:
Non-kuttl test execution was removed in a previous PR as the 'printer' package is no longer available in "sigs.k8s.io/controller-runtime/pkg/envtest/printer"

Which issue(s) this PR fixes:

Fixes #?
GITOPS-4777

How to test changes / Special notes to the reviewer:
make test-e2e should now execute (without RunSpecsWithDefaultAndCustomReporters)

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign svghadi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[svghadi]

I see the non default e2e tests suite is failing with

go test -p 1 -timeout 1h ./test/e2e -coverprofile cover.out -ginkgo.v
ok  	github.com/redhat-developer/gitops-operator/test/e2e	581.156s	coverage: [no statements]
go test -p 1 -timeout 1h ./test/nondefaulte2e -coverprofile cover.out -ginkgo.v
....
2024-07-25T11:52:55Z	ERROR	controller-runtime.source.EventHandler	kind must be registered to the Scheme	{"error": "no kind is registered for the type v1alpha1.NotificationsConfiguration in scheme \"k8s.io/client-go/kubernetes/scheme/register.go:80\""}

We probably need the same import fix as the one made in test/e2e/suite_test.go. - @trdoyle81
here:

gitops-operator/test/nondefaulte2e/suite_test.go

Line 97 in 13cd661

Expect(argoapi.AddToScheme(scheme.Scheme)).NotTo(HaveOccurred())

[svghadi]

Thanks @trdoyle81. Seems like import changes worked. Left a small suggestion, rest all looks good. Could you also fix the DCO CI job by signing the commits?

[openshift-ci]

@trdoyle81: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	744f0c5	link	true	/test unit
ci/prow/v4.12-e2e	744f0c5	link	true	/test v4.12-e2e
ci/prow/v4.12-ci-index-gitops-operator-bundle	744f0c5	link	true	/test v4.12-ci-index-gitops-operator-bundle
ci/prow/v4.12-images	744f0c5	link	true	/test v4.12-images
ci/prow/v4.13-ci-index-gitops-operator-bundle	744f0c5	link	true	/test v4.13-ci-index-gitops-operator-bundle
ci/prow/v4.12-kuttl-sequential	744f0c5	link	true	/test v4.12-kuttl-sequential
ci/prow/v4.12-kuttl-parallel	744f0c5	link	true	/test v4.12-kuttl-parallel
ci/prow/v4.13-e2e	744f0c5	link	true	/test v4.13-e2e
ci/prow/v4.13-images	744f0c5	link	true	/test v4.13-images
ci/prow/v4.13-kuttl-parallel	744f0c5	link	true	/test v4.13-kuttl-parallel
ci/prow/v4.13-kuttl-sequential	744f0c5	link	true	/test v4.13-kuttl-sequential
ci/prow/v4.14-ci-index-gitops-operator-bundle	744f0c5	link	true	/test v4.14-ci-index-gitops-operator-bundle
ci/prow/v4.14-e2e	744f0c5	link	true	/test v4.14-e2e
ci/prow/v4.14-kuttl-parallel	744f0c5	link	true	/test v4.14-kuttl-parallel
ci/prow/v4.14-images	744f0c5	link	true	/test v4.14-images
ci/prow/v4.14-kuttl-sequential	744f0c5	link	true	/test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.