Fix 'Unable to retrieve current OCP version: Malformed version' when …

…running unit tests (#729) * Fix 'Unable to retrieve current OCP version: Malformed version' when running unit tests Signed-off-by: Jonathan West <[email protected]> * Fix 'Unable to retrieve current OCP version: Malformed version' when running unit tests Signed-off-by: Jonathan West <[email protected]> --------- Signed-off-by: Jonathan West <[email protected]>
redhat-developer · Jun 18, 2024 · b134408 · b134408
1 parent e32261b
commit b134408
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/controllers/argocd_metrics_controller.go b/controllers/argocd_metrics_controller.go
@@ -362,6 +362,10 @@ func (r *ArgoCDMetricsReconciler) reconcileOperatorMetricsServiceMonitor(reqLogg
 
 	data, err := os.ReadFile(operatorPodNamespacePath)
 	if err != nil {
+		if os.IsNotExist(err) {
+			reqLogger.Info(fmt.Sprintf("Unable to retrieve the operator's running namespace via '%s': you should only see this message when running within unit tests, otherwise it is an error.", operatorPodNamespacePath))
+			return nil
+		}
 		reqLogger.Error(err, "Error retrieving operator's running namespace")
 		return err
 	}