Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Image Builder Updates #256

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

nasx
Copy link
Collaborator

@nasx nasx commented Dec 21, 2023

  • API/CLI Changes with Image Builder
  • Support for Multiple Image Builder Pools
  • Nexus Operator Deprecated/Removed

@sabre1041
Copy link
Contributor

@nasx There appears to be conflicts

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

- name: Generate In-Memory Inventory of Image Builder VM(s)
ansible.builtin.add_host:
ansible_ssh_host: "{{ item.status.interfaces[0].ipAddress }}"
ansible_ssh_port: "22"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not introduced in this PR, thoughts on making the SSH port configurable across the project?

NEXUS_ADMIN_USERNAME=$(oc get secrets ${SERVICE_NAME}-admin-credentials -o jsonpath='{ .data.username }' | base64 -d)
NEXUS_ADMIN_PASSWORD=$(oc get secrets ${SERVICE_NAME}-admin-credentials -o jsonpath='{ .data.password }' | base64 -d)
NEXUS_ADMIN_USERNAME=admin
# NEXUS_ADMIN_PASSWORD=$(oc get secrets ${SERVICE_NAME}-admin-credentials -o jsonpath='{ .data.password }' | base64 -d)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants