Pass extra ansible vars to kickstart task #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordigilh
commented
Feb 4, 2022
jordigilh
force-pushed
the
add_extra_variable_pipelinearg
branch
from
21068e7
to
4c83fb9
Compare
bbethell-1
approved these changes
Feb 7, 2022
|
@nasx @sabre1041 This PR is ready as well. I have no plans to make further changes right now, pending your feedback 😉 |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parameter to the
rfe-kickstart-pipelineto allow passing additional values to ansible to be used during the template parsing of the kickstart file. This will allow customizing the kickstart file further than just the ostree url.Example:
tkn pipeline start rfe-kickstart-pipeline -n rfe -s rfe-automation -p extra-template-variables="yggdrasil_http_api_url=$yggdrasil_http_api_url os_name=rhel" ...@nasx @sabre1041 can you take a look?