Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed composer types for RHEL to align with release 8.5 #235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jordigilh
Copy link
Contributor

@jordigilh jordigilh commented Jan 25, 2022

In RHEL 8.5, the composer types rhel-edge-commit and rhel-edge-container have been renamed to edge-commit and edge-container respectivelly.

$> cat /etc/redhat-release 
Red Hat Enterprise Linux release 8.5 (Ootpa)
$> compose-cli compose types |grep edge
edge-commit
edge-container
edge-installer
edge-raw-image
edge-simplified-installer

@ygalblum
Copy link
Contributor

LGTM

@sabre1041
Copy link
Contributor

@jordigilh should we add the composer type as a variable in the event there is a need to support older versions of RHEL

@jordigilh
Copy link
Contributor Author

@jordigilh should we add the composer type as a variable in the event there is a need to support older versions of RHEL

I'm already parametrizing it for Fedora/RHEL, we could use that ansible task to tweak the type even further based on the RHEL version.
Keep in mind that we'd also have to manage the different port exposed in the image generated by the edge-container type: in RHEL 8.4 is 80 but in RHEL 8.5 they moved to 8080.

@sabre1041
Copy link
Contributor

@jordigilh sigh you are right :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants