fix default value for *_credentials_secure_logging in README #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdanielsson
requested changes
Dec 3, 2024
| @@ -38,7 +38,7 @@ Enabling this will enforce configurtion without specifying every option in the c | |||
|
|
|||
| |Variable Name|Default Value|Required|Description| | |||
| |:---:|:---:|:---:|:---:| | |||
| |`controller_configuration_credentials_enforce_defaults`|`false`|no|Whether or not to enforce default option values on only the applications role| | |||
| |`controller_configuration_credentials_enforce_defaults`|`true`|no|Whether or not to enforce default option values on only the applications role| | |||
There was a problem hiding this comment.
I believe you meant, controller_configuration_credentials_secure_logging not controller_configuration_credentials_enforce_defaults
There was a problem hiding this comment.
@djdanielsson Thank you for review. I fixed it.
|
Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix default value for
*_credentials_secure_loggingin README.How should this be tested?
N/A (Document only)
Is there a relevant Issue open for this?
resolves #990
Other Relevant info, PRs, etc
N/A (Document only)