Skip to content

Commit

Permalink
fix: use --random_generator=tausworthe64
Browse files Browse the repository at this point in the history
If disks are large enough then FIO will write to stdout a warning that
the default random generator is not sufficient. As this is written to
stdout the subsequent attempt to parse the JSON will fail as it contains
the warning before the JSON object.

To fix we can set the random generator to `tausworthe64` which will
suppress the warning allow for the JSON to be parsed without error.

This issue has been noticed on disks around 64TB in size however could
occur on smaller disks.
  • Loading branch information
jackhodgkiss committed Nov 15, 2024
1 parent 2fa59a5 commit 4bcf169
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hardware/benchmark/disk.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def run_fio(hw_lst, disks_list, mode, io_size, time, rampup_time):
os.remove(myfile)
fio = ("fio --ioengine=libaio --invalidate=1 --ramp_time=%d --iodepth=32 "
"--runtime=%d --time_based --direct=1 --output-format=json "
"--bs=%s --rw=%s" % (rampup_time, time, io_size, mode))
"--bs=%s --rw=%s --random_generator=tausworthe64" % (rampup_time, time, io_size, mode))

global_disk_list = ''
for disk in disks_list:
Expand Down

0 comments on commit 4bcf169

Please sign in to comment.