chore(RHTAPWATCH-691): verify-rpms test to fail on unsigned RPMs #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yftacherzog
reviewed
Dec 27, 2023
Omeramsc
force-pushed
the
RHTAPWATCH-691
branch
from
76bd495 to
f69ca56
Compare
yftacherzog
reviewed
Dec 27, 2023
Omeramsc
force-pushed
the
RHTAPWATCH-691
branch
from
f69ca56 to
4eac2b2
Compare
yftacherzog
reviewed
Dec 27, 2023
Omeramsc
force-pushed
the
RHTAPWATCH-691
branch
from
4eac2b2 to
72a6ef5
Compare
yftacherzog
reviewed
Dec 31, 2023
The e2e test for the verify-rpms script checked only a scenario where it should not fail when unsigned RPMs or errors exists. Adds tests for multiple scenarios - where the script should and should not fail when encountering unsigned RPMs or other errors. This lead to a refactor which changed the failing responsability from which fails the process from "generate_output" to the main function. Signed-off-by: Omer <[email protected]>
Omeramsc
force-pushed
the
RHTAPWATCH-691
branch
from
72a6ef5 to
8871cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e test for the verify-rpms script checked
only a scenario where it should not fail when unsigned RPMs
or errors exists.
Adds tests for multiple scenarios - where the script should
and should not fail when encountering unsigned RPMs or other errors.
This lead to a refactor which changed the failing responsability
from which fails the process from "generate_output" to the
main function.