Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RHTAPWATCH-686): handle runner exceptions #25

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

avi-biton
Copy link
Collaborator

Except exceptions from runner
Add errors to the output
Add unit tests

Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the format between the two kind of failures should be similar. Otherwise, lgtm.

Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yftacherzog
Copy link
Member

/test

@yftacherzog
Copy link
Member

/ok-to-test

@yftacherzog
Copy link
Member

/retest

@ifireball
Copy link
Collaborator

@yftacherzog If you're not seeing the pipeline running in RHTAP, perhaps this PR is not based on a version of the code that contains the pipeline

Except exceptions from runner
Add errors to the output
Add unit tests

Signed-off-by: Avi Biton <[email protected]>
@yftacherzog yftacherzog merged commit 72beb04 into redhat-appstudio:main Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants