Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RHTAPWATCH-634): request ODCS compose #17

Merged
merged 1 commit into from
Dec 20, 2023
Merged

chore(RHTAPWATCH-634): request ODCS compose #17

merged 1 commit into from
Dec 20, 2023

Conversation

Omeramsc
Copy link
Member

Implement ODCSRequestor, allowing requesting ODCS
for a compose file.

@yftacherzog yftacherzog marked this pull request as draft December 17, 2023 09:28
@yftacherzog
Copy link
Member

@Omeramsc changed to draft so that others won't spend time reviewing it until we made the changes we discussed this morning.

@Omeramsc Omeramsc marked this pull request as ready for review December 17, 2023 14:38
gbenhaim
gbenhaim requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@gbenhaim gbenhaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! I've added some comments.

tests/test_odcs_requester.py Outdated Show resolved Hide resolved
generate_compose/odcs_requester.py Show resolved Hide resolved
generate_compose/odcs_requester.py Show resolved Hide resolved
tests/test_odcs_requester.py Outdated Show resolved Hide resolved
tests/test_odcs_requester.py Outdated Show resolved Hide resolved
tests/test_odcs_requester.py Outdated Show resolved Hide resolved
tests/test_odcs_requester.py Outdated Show resolved Hide resolved
@ifireball
Copy link
Collaborator

@Omeramsc you need to rebase this to get a build from RHTAP

@Omeramsc Omeramsc self-assigned this Dec 18, 2023
@Omeramsc
chore(RHTAPWATCH-634): request ODCS compose
60d0a42 
Implement ODCSRequestor, allowing requesting ODCS
for multiple compose files, per number of sources.

Signed-off-by: Omer <[email protected]>
@yftacherzog
Copy link
Member

yftacherzog commented Dec 19, 2023 •
edited
Loading

@Omeramsc can you verify that you're able to use the code you wrote here to request a compose of some sort? You can use the equivalent inputs to what we have here: https://github.com/redhat-appstudio/tools/blob/main/generate_compose/odcs_ping.py#L33-L34
You'd need to kinit before

@Omeramsc
Copy link
Member Author

@Omeramsc can you verify that you're able to use the code you wrote here to request a compose of some sort? You can use the equivalent inputs to what we have here: https://github.com/redhat-appstudio/tools/blob/main/generate_compose/odcs_ping.py#L33-L34 You'd need to kinit before

Verified working
http://download.eng.bos.redhat.com/odcs/prod/odcs-2628389/compose/Temporary/odcs-2628389.repo

@yftacherzog yftacherzog merged commit dfd7af2 into redhat-appstudio:main Dec 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifireball ifireball ifireball left review comments

@gbenhaim gbenhaim gbenhaim approved these changes

@avi-biton avi-biton Awaiting requested review from avi-biton

@yftacherzog yftacherzog Awaiting requested review from yftacherzog

Assignees

@Omeramsc Omeramsc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Omeramsc @yftacherzog @ifireball @gbenhaim